uptake / autofocus

Deep learning computer vision for classifying wildlife in camera trap images
BSD 3-Clause "New" or "Revised" License
54 stars 30 forks source link

Predict app #121

Open DigitalPhilosopher opened 5 years ago

DigitalPhilosopher commented 5 years ago

Feel free to open a PR before all of these items have been completed.

Pull Request Checklist

Maintainer's responsibilities:

gsganden commented 5 years ago

Got it, thanks! Will review at my earliest opportunity.

DigitalPhilosopher commented 5 years ago

Hey @gsganden, is there anything else you would change in my PR? I would be very happy with some advice and comments on my changes. Thanks very much :)

gsganden commented 5 years ago

It might take me a little while, but I will get to it!

DigitalPhilosopher commented 5 years ago

Hey @gsganden I revisited the code and made it more functional and removed most of the object orientation.

However, I kept the File (now TemporaryFile) and ZipArchive as classes, as said before. If you really don't favor this approach, I would be willing to change it as well, but I think it adds a lot to the simplicity of the code and would favor to keep it. What do you think?