Open DigitalPhilosopher opened 5 years ago
Got it, thanks! Will review at my earliest opportunity.
Hey @gsganden, is there anything else you would change in my PR? I would be very happy with some advice and comments on my changes. Thanks very much :)
It might take me a little while, but I will get to it!
Hey @gsganden I revisited the code and made it more functional and removed most of the object orientation.
However, I kept the File (now TemporaryFile) and ZipArchive as classes, as said before. If you really don't favor this approach, I would be willing to change it as well, but I think it adds a lot to the simplicity of the code and would favor to keep it. What do you think?
Feel free to open a PR before all of these items have been completed.
Pull Request Checklist
./.ci/local_checks.sh
passes locally. (The app must be running. SeeREADME.md
for instructions.)Maintainer's responsibilities:
_version.py
has been updated.CHANGELOG.md
has been updated.