uptake / autofocus

Deep learning computer vision for classifying wildlife in camera trap images
BSD 3-Clause "New" or "Revised" License
54 stars 30 forks source link

Run tests against running container on travis #132

Open davidwilby opened 4 years ago

davidwilby commented 4 years ago

Resolves #110 by modifying the travis config to:

Note This doesn't work with the OSX build because Services are not supported on osx for travis. However, docker is OS agnostic, so this shouldn't matter. (it's not clear to me what the OSX build is for)

To do before/on merging:

Pull Request Checklist

Maintainer's responsibilities:

davidwilby commented 4 years ago

@gsganden are there particular changes you'd like to be made? I expect the travis checks to pass once the AWS environment variables for the repo are added on travis and the build re-run.

PS: Another reason to take out the OSX build: https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing

jameslamb commented 4 years ago

@gsganden do you need me to review anything on this?

gsganden commented 4 years ago

Nah @jameslamb I can take it.

jameslamb commented 4 years ago

Nah @jameslamb I can take it.

ok cool, I'll remove myself from this one. Still happy to hep on this repo if you ever need me!

jameslamb commented 4 years ago

it's ok with me if you want to take me out of CODEOWNERS and just manually request me when needed

gsganden commented 4 years ago

it's ok with me if you want to take me out of CODEOWNERS and just manually request me when needed

Done

gsganden commented 4 years ago

I believe I added the credentials, but the build isn't finding them. Do you know what to do?

image

davidwilby commented 4 years ago

It might be down to one or both of:

gsganden commented 3 years ago

I'm seeing the same error message after changing the variable names to all caps. Any ideas?

image

jameslamb commented 3 years ago

If you're changing things in the Travis console and then clicking "rebuild", it's possible that that won't work because stuff is cached. I've noticed behavior like that with other CI services before.

You could try pushing an empty commit to this branch. I keep this alias in my ~/.bash_profile for that purpose:

push_empty (){
    git commit --allow-empty -m "empty commit"
    git push origin HEAD
}