search

uptake / pkgnet

R package for analyzing other R packages via graph representations of their dependencies
https://uptake.github.io/pkgnet/
Other
152 stars 37 forks source link

release: v0.4.1 #270

Closed bburns632 closed 4 years ago

bburns632 commented 4 years ago

Please see draft NEWS.md for details.

This PR is in preparation for a new submission to CRAN.

codecov-io commented 4 years ago

Codecov Report

Merging #270 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #270   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files          12       12           
  Lines         929      929           
=======================================
  Hits          859      859           
  Misses         70       70
Impacted Files Coverage Δ
R/AbstractGraphReporter.R 90.00% <ø> (ø)
R/AbstractPackageReporter.R 100.00% <ø> (ø)
R/CreatePackageReport.R 94.28% <ø> (ø)
R/CreatePackageVignette.R 100.00% <ø> (ø)
R/DefaultReporters.R 100.00% <ø> (ø)
R/DependencyReporter.R 79.78% <ø> (ø)
R/FunctionReporter.R 93.25% <ø> (ø)
R/GraphClasses.R 93.15% <ø> (ø)
R/InheritanceReporter.R 100.00% <ø> (ø)
R/SummaryReporter.R 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9701f09...dd1d1e6. Read the comment docs.

bburns632 commented 4 years ago

ok @jayqi @jameslamb , this PR has been r-devel tested and will be submitted some point tomorrow.

I updated the website within this PR, so it will help to view this by commits. Before merging, I'll squash the commits.

The only major change in the website is the reference section (see this commit).

bburns632 commented 4 years ago

submitted. might take some extra time with the maintainer email change.

jameslamb commented 4 years ago

submitted. might take some extra time with the maintainer email change.

great, thank you! Sorry I didn't get #243 done in time for the release

bburns632 commented 4 years ago

Well it came back with errors, so we could get it in if you're ready

On Sun, Mar 29, 2020, 4:57 PM James Lamb notifications@github.com wrote:

submitted. might take some extra time with the maintainer email change.

great, thank you! Sorry I didn't get #243 https://github.com/uptake/pkgnet/pull/243 done in time for the release

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/uptake/pkgnet/pull/270#issuecomment-605708125, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3FDSYZFCZCUI7NGWC65RDRJ6757ANCNFSM4LVJCQ7Q .

jameslamb commented 4 years ago

Well it came back with errors, so we could get it in if you're ready … On Sun, Mar 29, 2020, 4:57 PM James Lamb @.***> wrote: submitted. might take some extra time with the maintainer email change. great, thank you! Sorry I didn't get #243 <#243> done in time for the release — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#270 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3FDSYZFCZCUI7NGWC65RDRJ6757ANCNFSM4LVJCQ7Q .

let's do it for the next release, if that's ok

bburns632 commented 4 years ago

That works. Next release it is.

On Sun, Mar 29, 2020, 8:37 PM James Lamb notifications@github.com wrote:

Well it came back with errors, so we could get it in if you're ready … <#m4946827835441467025> On Sun, Mar 29, 2020, 4:57 PM James Lamb @.***> wrote: submitted. might take some extra time with the maintainer email change. great, thank you! Sorry I didn't get #243 https://github.com/uptake/pkgnet/pull/243 <#243 https://github.com/uptake/pkgnet/pull/243> done in time for the release — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#270 (comment) https://github.com/uptake/pkgnet/pull/270#issuecomment-605708125>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3FDSYZFCZCUI7NGWC65RDRJ6757ANCNFSM4LVJCQ7Q .

let's do it for the next release, if that's ok

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/uptake/pkgnet/pull/270#issuecomment-605738426, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3FDS5PERZSL635PH6R5DDRJ7ZT3ANCNFSM4LVJCQ7Q .

bburns632 commented 4 years ago

Trying this process to test on CRAN's windows servers b4 submission.

https://win-builder.r-project.org/

bburns632 commented 4 years ago

Still failed. Here's CRAN windows log. Will be deleted in 2 days. Again, this passes otherwise.

this notification has been generated automatically. Your package pkgnet_0.4.1.tar.gz has been built (if working) and checked for Windows. Please check the log files and (if working) the binary package at: https://win-builder.r-project.org/KuN66RD3DA7f The files will be removed after roughly 72 hours. Installation time in seconds: 17 Check time in seconds: 164 Status: 1 WARNING, 1 NOTE R version 4.0.0 alpha (2020-03-26 r78078)

On Sun, Mar 29, 2020, 8:53 PM Brian Burns brian.burns09@gmail.com wrote:

That works. Next release it is.

On Sun, Mar 29, 2020, 8:37 PM James Lamb notifications@github.com wrote:

Well it came back with errors, so we could get it in if you're ready … <#m_927491561505377187_m4946827835441467025> On Sun, Mar 29, 2020, 4:57 PM James Lamb @.***> wrote: submitted. might take some extra time with the maintainer email change. great, thank you! Sorry I didn't get #243 https://github.com/uptake/pkgnet/pull/243 <#243 https://github.com/uptake/pkgnet/pull/243> done in time for the release — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#270 (comment) https://github.com/uptake/pkgnet/pull/270#issuecomment-605708125>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3FDSYZFCZCUI7NGWC65RDRJ6757ANCNFSM4LVJCQ7Q .

let's do it for the next release, if that's ok

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/uptake/pkgnet/pull/270#issuecomment-605738426, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3FDS5PERZSL635PH6R5DDRJ7ZT3ANCNFSM4LVJCQ7Q .

jameslamb commented 4 years ago

Still failed. Here's CRAN windows log. Will be deleted in 2 days. Again, this passes otherwise. this notification has been generated automatically. Your package pkgnet_0.4.1.tar.gz has been built (if working) and checked for Windows. Please check the log files and (if working) the binary package at: https://win-builder.r-project.org/KuN66RD3DA7f The files will be removed after roughly 72 hours. Installation time in seconds: 17 Check time in seconds: 164 Status: 1 WARNING, 1 NOTE R version 4.0.0 alpha (2020-03-26 r78078) … On Sun, Mar 29, 2020, 8:53 PM Brian Burns @.> wrote: That works. Next release it is. On Sun, Mar 29, 2020, 8:37 PM James Lamb @.> wrote: > Well it came back with errors, so we could get it in if you're ready > … <#m_927491561505377187_m4946827835441467025> > On Sun, Mar 29, 2020, 4:57 PM James Lamb @.***> wrote: submitted. > might take some extra time with the maintainer email change. great, thank > you! Sorry I didn't get #243 <#243> > <#243 <#243>> done in time for the > release — You are receiving this because you authored the thread. Reply to > this email directly, view it on GitHub <#270 (comment) > <#270 (comment)>>, or > unsubscribe > https://github.com/notifications/unsubscribe-auth/AF3FDSYZFCZCUI7NGWC65RDRJ6757ANCNFSM4LVJCQ7Q > . > > let's do it for the next release, if that's ok > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#270 (comment)>, or > unsubscribe > https://github.com/notifications/unsubscribe-auth/AF3FDS5PERZSL635PH6R5DDRJ7ZT3ANCNFSM4LVJCQ7Q > . >

I don't see anything obviously problematic in the running R 4.0.0 changelog.

I'm so confused :/

bburns632 commented 4 years ago

See the check00.log k. The above link.

On Mon, Mar 30, 2020, 9:37 AM James Lamb notifications@github.com wrote:

Still failed. Here's CRAN windows log. Will be deleted in 2 days. Again, this passes otherwise. this notification has been generated automatically. Your package pkgnet_0.4.1.tar.gz has been built (if working) and checked for Windows. Please check the log files and (if working) the binary package at: https://win-builder.r-project.org/KuN66RD3DA7f The files will be removed after roughly 72 hours. Installation time in seconds: 17 Check time in seconds: 164 Status: 1 WARNING, 1 NOTE R version 4.0.0 alpha (2020-03-26 r78078) … <#m7871850182882101189> On Sun, Mar 29, 2020, 8:53 PM Brian Burns @.> wrote: That works. Next release it is. On Sun, Mar 29, 2020, 8:37 PM James Lamb @.> wrote: > Well it came back with errors, so we could get it in if you're ready > … <#m_927491561505377187_m4946827835441467025> > On Sun, Mar 29, 2020, 4:57 PM James Lamb @.***> wrote: submitted. > might take some extra time with the maintainer email change. great, thank > you! Sorry I didn't get

243 https://github.com/uptake/pkgnet/pull/243 <#243

https://github.com/uptake/pkgnet/pull/243> > <#243 https://github.com/uptake/pkgnet/pull/243 <#243 https://github.com/uptake/pkgnet/pull/243>> done in time for the > release — You are receiving this because you authored the thread. Reply to

this email directly, view it on GitHub <#270 https://github.com/uptake/pkgnet/pull/270 (comment) > <#270 (comment) https://github.com/uptake/pkgnet/pull/270#issuecomment-605708125>>, or unsubscribe > https://github.com/notifications/unsubscribe-auth/AF3FDSYZFCZCUI7NGWC65RDRJ6757ANCNFSM4LVJCQ7Q . > > let's do it for the next release, if that's ok > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#270 (comment) https://github.com/uptake/pkgnet/pull/270#issuecomment-605738426>, or > unsubscribe > https://github.com/notifications/unsubscribe-auth/AF3FDS5PERZSL635PH6R5DDRJ7ZT3ANCNFSM4LVJCQ7Q . >

I don't see anything obviously problematic in the running R 4.0.0 changelog https://cran.r-project.org/doc/manuals/r-devel/NEWS.html.

I'm so confused :/

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/uptake/pkgnet/pull/270#issuecomment-606038914, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3FDS6G6BG43TCMZOIPN63RKCVCBANCNFSM4LVJCQ7Q .

jameslamb commented 4 years ago

See the check00.log k. The above link. … On Mon, Mar 30, 2020, 9:37 AM James Lamb @.> wrote: Still failed. Here's CRAN windows log. Will be deleted in 2 days. Again, this passes otherwise. this notification has been generated automatically. Your package pkgnet_0.4.1.tar.gz has been built (if working) and checked for Windows. Please check the log files and (if working) the binary package at: https://win-builder.r-project.org/KuN66RD3DA7f The files will be removed after roughly 72 hours. Installation time in seconds: 17 Check time in seconds: 164 Status: 1 WARNING, 1 NOTE R version 4.0.0 alpha (2020-03-26 r78078) … <#m7871850182882101189> On Sun, Mar 29, 2020, 8:53 PM Brian Burns @.> wrote: That works. Next release it is. On Sun, Mar 29, 2020, 8:37 PM James Lamb @.> wrote: > Well it came back with errors, so we could get it in if you're ready > … <#m_927491561505377187_m4946827835441467025> > On Sun, Mar 29, 2020, 4:57 PM James Lamb @.> wrote: submitted. > might take some extra time with the maintainer email change. great, thank > you! Sorry I didn't get #243 <#243> <#243 <#243>> > <#243 <#243> <#243 <#243>>> done in time for the > release — You are receiving this because you authored the thread. Reply to > this email directly, view it on GitHub <#270 <#270> (comment) > <#270 (comment) <#270 (comment)>>>, or > unsubscribe > https://github.com/notifications/unsubscribe-auth/AF3FDSYZFCZCUI7NGWC65RDRJ6757ANCNFSM4LVJCQ7Q > . > > let's do it for the next release, if that's ok > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#270 (comment) <#270 (comment)>>, or > unsubscribe > https://github.com/notifications/unsubscribe-auth/AF3FDS5PERZSL635PH6R5DDRJ7ZT3ANCNFSM4LVJCQ7Q > . > I don't see anything obviously problematic in the running R 4.0.0 changelog https://cran.r-project.org/doc/manuals/r-devel/NEWS.html. I'm so confused :/ — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#270 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3FDS6G6BG43TCMZOIPN63RKCVCBANCNFSM4LVJCQ7Q .

oh yeah I see the error. Sorry, let me clarify what I meant...when I look at the changes that have been introduced in R 4.0.0 so far, I don't see any which are obviously to blame for our package now failing

jayqi commented 4 years ago

It doesn't necessarily have to be something we changed. The creation of the temporary library failed, and that could have happened because R on Windows changed.

bburns632 commented 4 years ago

^This. Especially since it's only the one machine type that fails, all others fine.

On Mon, Mar 30, 2020, 10:05 AM Jay Qi notifications@github.com wrote:

It doesn't necessarily have to be something we changed. The creation of the temporary library failed, and that could have happened because R on Windows changed.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/uptake/pkgnet/pull/270#issuecomment-606055908, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF3FDS2R2HDZK3BUIHLU7HTRKCYMRANCNFSM4LVJCQ7Q .

jameslamb commented 4 years ago

this link I shared is everything that has changed on R 4.0.0 so far relative to R 3.6.3: https://cran.r-project.org/doc/manuals/r-devel/NEWS.html

I personally didn't see anything in there that I could connect to the errors in the log Brian shared, but it's a lot of stuff and the connection might not be a clean / obvious one so likely I just missed it

bburns632 commented 4 years ago

Two interesting things from that log:

  1. baseballstats is already loaded somehow.
  2. the path to baseballstats is wrong (extra directory at the end)

My first thoughts was that #2 was caused by number #1 but maybe not.

image

bburns632 commented 4 years ago

Gents, I went with the nuclear option and just removed vignettes from CRAN submission. The github website will still have the articles.

I left the commits above so you can see what I tried. I have no idea why the repo path gets corrupted on that one machine.

Will clean/squash commits and merge once we're up on CRAN.

bburns632 commented 4 years ago

Done. V0.4.1 is up on CRAN. 🎉

jameslamb commented 4 years ago

Done. V0.4.1 is up on CRAN. 🎉

woo thanks!