search

uptake / pkgnet

R package for analyzing other R packages via graph representations of their dependencies
https://uptake.github.io/pkgnet/
Other
152 stars 37 forks source link

[ci] remove devtools #280

Closed jameslamb closed 4 years ago

jameslamb commented 4 years ago

This pull request proposes two changes to speed up this project's CI:

codecov-commenter commented 4 years ago

Codecov Report

Merging #280 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #280   +/-   ##
=======================================
  Coverage   92.46%   92.46%           
=======================================
  Files          12       12           
  Lines         929      929           
=======================================
  Hits          859      859           
  Misses         70       70

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b01bcb9...16de64c. Read the comment docs.

jameslamb commented 4 years ago

Alright SO...this didn't seem to make the builds any faster. But I still think it's a good idea to not rely on devtools, since it's so expensive.

image

most recent master:

this PR

jameslamb commented 4 years ago

Could I get a review on this?

jameslamb commented 4 years ago

LGTM. I just manually kicked off the build again since it's been a while. Also curious how much variation we get with the times.

yeah I'm not sure.Here's the most recent one you kicked off:

image