search

uptake / pkgnet

R package for analyzing other R packages via graph representations of their dependencies
https://uptake.github.io/pkgnet/
Other
155 stars 37 forks source link

AbstractGraphReporter.network_measures should not be abstract #281

Closed jayqi closed 4 years ago

jayqi commented 4 years ago

AbstractGraphReporter.network_measures should not be abstract. The change in this PR implements the same logic as in the R package. For now though, trying to call it will result in pkg_graph.graph_measures() raising a NotImplementedError, which is sensible.

Fixes the issue reported here: https://github.com/uptake/pkgnet/issues/267#issuecomment-685457478

bburns632 commented 4 years ago

LGTM. There's a failed test due to gnutls loading failure in Travis. I'd like to look into that, but if we're still looking into that by this time tomorrow, it's probably safe to merge.

jayqi commented 4 years ago

It might be that the Mac build (with the gnutls error) was canceled because the Linux build had a C++ compilation error when installing devtools. The builds don't really matter at this point because the py-pkg branch doesn't touch the R code, and I don't have tests for the Python package yet.

jameslamb commented 4 years ago

It might be that the Mac build (with the gnutls error) was canceled because the Linux build had a C++ compilation error when installing devtools. The builds don't really matter at this point because the py-pkg branch doesn't touch the R code, and I don't have tests for the Python package yet.

@jayqi I'm ok with this, you can use your admin rights to merge this one