uptake / updraft

R package for building flexible workflows

Other

13 stars 12 forks source link

Create .gitignore #22

Closed zaynaib closed 6 years ago

zaynaib commented 6 years ago

Created a gitignore file. Are there any paths or files your team want to be ignored?

jameslamb commented 6 years ago

Hey @zaynaib thanks for doing this!

If you're not sure where to start, I think this is a good set for an R project:

# R stuff
*.Rhistory
*.Rproj
*.rda
*.rds
*.Rdata

# data files
*.csv
**/*.csv
**/*.xlsx
**/*.pdf

# other misc stuff
*.DS_Store

codecov-io commented 6 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   82.56%   82.56%           
=======================================
  Files          14       14           
  Lines         625      625           
=======================================
  Hits          516      516           
  Misses        109      109

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d5a90e7...784938f. Read the comment docs.

jameslamb commented 6 years ago

Great thanks! Don't worry about the failing Travis stuff...totally unrelated to your code.

@cwschultz88 from my perspective, this PR is good to go.

@zaynaib We really appreciate you making this contribution and hope you'll come back to make more!

zaynaib commented 6 years ago

@jameslamb Two questions. 1.) Do you know of any resources where I can about vignette with R? 2.) Is there anything else you need me to do for this PR? Or any other issues you need help with?

jameslamb commented 6 years ago

@zaynaib Nothing else needed for this particular PR! @cwschultz88 is the maintainer so he'll be the one to merge this.

If you're interested in learning about vignettes in R packages, Hadley's book is a great resource: http://r-pkgs.had.co.nz/vignettes.html

If you're looking for other issues to pick up, check out pkgnet!. We have quite a few open issues, and perhaps looking through the code you'll find more. Any contributions are welcomed!

cwschultz88 commented 6 years ago

Everything looks great -- thanks for the contribution!