uptake / updraft

R package for building flexible workflows
Other
13 stars 12 forks source link

closes #32 #34

Closed amysheep closed 5 years ago

amysheep commented 5 years ago

closes #32

codecov-io commented 5 years ago

Codecov Report

Merging #34 into master will increase coverage by 0.15%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   82.72%   82.88%   +0.16%     
==========================================
  Files          14       14              
  Lines         625      625              
==========================================
+ Hits          517      518       +1     
+ Misses        108      107       -1
Impacted Files Coverage Δ
R/workflow_dag.R 92.09% <0%> (+0.46%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a10966b...84d9ecd. Read the comment docs.

amysheep commented 5 years ago

@jameslamb ready to merge?

jameslamb commented 5 years ago

Thanks for doing this!

@mjermann is the official maintainer and needs to review. I'm just the person with super-triple-admin powers who can click buttons if maintainers need 😀

mjermann commented 5 years ago

Thanks for submitting - will take a look by tonight!

On Thu, May 2, 2019 at 11:16 AM James Lamb notifications@github.com wrote:

@jameslamb https://github.com/jameslamb requested your review on: #34 https://github.com/UptakeOpenSource/updraft/pull/34 closes #32 https://github.com/UptakeOpenSource/updraft/issues/32.

— You are receiving this because your review was requested.

Reply to this email directly, view it on GitHub https://github.com/UptakeOpenSource/updraft/pull/34#event-2315012403, or mute the thread https://github.com/notifications/unsubscribe-auth/ABFQEDJGSL2VO46TLA6DWBDPTMHW3ANCNFSM4HJXGW6A .

-- Mike Jermann (630) 631 - 3082 mjermann@gmail.com