search

uptake / updraft

R package for building flexible workflows
Other
13 stars 12 forks source link

return(NULL) calls should be changed to return(invisible(NULL)) #7

Closed jameslamb closed 6 years ago

jameslamb commented 6 years ago

Very minor thing, but having return(NULL) can cause some weird things to happen in logs in certain situations.

Seeing this is always a bit confusing:

[INFO] doing some stuff...
[INFO] done
[INFO] doing other stuff....
NULL
[INFO] done
[INFO] moving on from stuff to things...

Using return(invisible(NULL)) everywhere would suppress these NULLs from being printed

cwschultz88 commented 6 years ago

Issue is address with last PR, closing this out!