Should remove reliance on test_aaa and test_zzz

uptake / updraft

R package for building flexible workflows

Other

13 stars 12 forks source link

Should remove reliance on test_aaa and test_zzz #8

Closed jameslamb closed 5 years ago

jameslamb commented 6 years ago

Doing those setup and cleaning operations in separate files where order matters makes it a bit harder to reason about the behavior of individual unit tests when they fail. If possible, it would be better to have unit tests be isolated.

@cwschultz88 if you say "nah this is totally a fine thing to do" and kill this issue, I won't fight too hard. Just putting it up for discussion

jameslamb commented 5 years ago

oh hey we can close this! @cwschultz88 did this as of https://github.com/UptakeOpenSource/updraft/commit/4c5a4d2a2fd49e9f545cf831c03f1a18459f8313