search

uptane / aktualizr

C++ Uptane Client
Mozilla Public License 2.0
15 stars 15 forks source link

Install cleanup #16

Closed pattivacek closed 2 years ago

pattivacek commented 2 years ago

FYI @mike-sul and @cajun-rat.

cajun-rat commented 2 years ago

lgtm. I had one query of whether CMAKE_INSTALL_BINDIR is actually going to end up as bin? If it doesn't, then it might be a change that breaks/changes the locations where the build output is placed. I didn't check, and it shouldn't be too hard to fix up meta-updater if the locations have shifted a bit. In any case they will have moved to a more standard location, so that seems like a net improvement to me.

pattivacek commented 2 years ago

I had one query of whether CMAKE_INSTALL_BINDIR is actually going to end up as bin?

Yes, I tested it. :) I compared the installation paths before and after this change and the only thing that changed was that the garage-sign libs no longer have an unnecessary /. in the middle.