search

uptane / aktualizr

C++ Uptane Client
Mozilla Public License 2.0
15 stars 15 forks source link

Support TUF-only verification in aktualizr-secondary. #23

Closed pattivacek closed 2 years ago

pattivacek commented 2 years ago

There are plenty of test cases to verify this but I'm still open to feedback. I also still need to work on the Primary side so that it doesn't try to send the Director metadata if it doesn't need to (and/or isn't available) in this case.

Update: Primary side works correctly now, too.

pattivacek commented 2 years ago

FYI @mike-sul @doanac. It also occurs to me that the version comparison logic might be similar to something you already have in aktualizr-lite.

pattivacek commented 2 years ago

I can't figure out why now the first test case is looping indefinitely in of these complicated tests. Everything else looks fine.

mike-sul commented 2 years ago

I can't figure out why now the first test case is looping indefinitely in of these complicated tests. Everything else looks fine.

I see lots of 

Failed to connect to the Secondary ( 127.0.0.1:36995): Connection refused

I guess, the secondary instance failed to start...

pattivacek commented 2 years ago

This is now ready for review (along with https://github.com/uptane/aktualizr/pull/24).

pattivacek commented 2 years ago

I've only gotten positive feedback here so far, so I will probably merge this in the next couple days if I don't hear any objections. I've been testing it thoroughly and have not had any issues.

mike-sul commented 2 years ago

It works for me.