search

uptane / aktualizr

C++ Uptane Client
Mozilla Public License 2.0
15 stars 15 forks source link

Add nop11 test from gitlab CI to github actions. #24

Closed pattivacek closed 2 years ago

pattivacek commented 2 years ago

Also match static-tests slightly more closely.

pattivacek commented 2 years ago

FYI @cajun-rat @tkfu. The main reason not to do this is to spare us minutes in our free Github account. Pretty sure we're low-enough traffic that we can spare the 7 minutes per run, though.

Anyone remember why we were running the crypto tests with the Focal static test run with gitlab but not on github? @mike-sul @lbonn perhaps? There was also a note about valgrind leaks on Focal, so that was configured as a debug build instead, but that didn't seem to be a problem here.

I'd also like to get codecov working again, and maybe even see about the package tests and the release process. Might not really be worth it if no one's really using it, though.

mike-sul commented 2 years ago

Anyone remember why we were running the crypto tests with the Focal static test run with gitlab but not on github?

No, I don't recall. I guess and iirc, it has to do with the fact that initially there was no any CI pipelines on github and then we started adding/moving the gitlab CI jobs to github.

cajun-rat commented 2 years ago

lgtm. 35 minutes to run the tests? C'mon Github, my laptop does it in 140s...

pattivacek commented 2 years ago

35 minutes to run the tests? C'mon Github, my laptop does it in 140s...

Yeah... my laptop isn't that fast, but still far better than Github.