uptane / aktualizr

C++ Uptane Client
Mozilla Public License 2.0
15 stars 15 forks source link

Reduce size of SotaUptaneClient's public interface #28

Closed cajun-rat closed 2 years ago

cajun-rat commented 2 years ago

I went through and found all the currently public member functions of SotaUptaneClient that are only called by test code and made them private and visible to the test using FRIEND_TEST. The idea here is to have a more manageable public interface to make refactoring simpler.

Signed-off-by: Phil Wise phil@phil-wise.com

mike-sul commented 2 years ago

I seem to recall a couple of these things were make public specifically for aktualizr-lite

The current version of aktualizr-lite doesn't depend on SotaUptaneClient, so any changes to it shouldn't impact aktualizr-lite.

pattivacek commented 2 years ago

The current version of aktualizr-lite doesn't depend on SotaUptaneClient, so any changes to it shouldn't impact aktualizr-lite.

Oh nice, I didn't realize that. Well, cool, then, this is probably good to go.