search

uptane / aktualizr

C++ Uptane Client
Mozilla Public License 2.0
15 stars 15 forks source link

Submodule update fails #29

Closed mike-sul closed 2 years ago

mike-sul commented 2 years ago

git submodule update --init --recursive fails for https://github.com/advancedtelematic/tuf-test-vectors repo. See below fro logs.

git submodule update --init --recursive
Submodule 'tests/tuf-test-vectors' (https://github.com/advancedtelematic/tuf-test-vectors/) registered for path 'tests/tuf-test-vectors'
Submodule 'third_party/googletest' (https://github.com/google/googletest.git) registered for path 'third_party/googletest'
Submodule 'third_party/jsoncpp' (https://github.com/open-source-parsers/jsoncpp) registered for path 'third_party/jsoncpp'
Cloning into '/home/mike/work/foundries/projects/uptane-aktualizr/tests/tuf-test-vectors'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'https://github.com/advancedtelematic/tuf-test-vectors/' into submodule path '/home/mike/work/foundries/projects/uptane-aktualizr/tests/tuf-test-vectors' failed
Failed to clone 'tests/tuf-test-vectors'. Retry scheduled
Cloning into '/home/mike/work/foundries/projects/uptane-aktualizr/third_party/googletest'...
Cloning into '/home/mike/work/foundries/projects/uptane-aktualizr/third_party/jsoncpp'...
Cloning into '/home/mike/work/foundries/projects/uptane-aktualizr/tests/tuf-test-vectors'...
ERROR: Repository not found.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'https://github.com/advancedtelematic/tuf-test-vectors/' into submodule path '/home/mike/work/foundries/projects/uptane-aktualizr/tests/tuf-test-vectors' failed
Failed to clone 'tests/tuf-test-vectors' a second time, aborting
pattivacek commented 2 years ago

Hmmm, that repo definitely still exists and has been working for me without a hitch. Can you do it manually?

However, it is annoying that the repo is still only available in the old advancedtelematic namespace. @tkfu do you have rights to fork/copy that repo to the uptane namespace? If so, can you fork it as well as meta-updater-raspberrypi, meta-updater-qemux86-64, and updater-repo? I'm not using those at the moment but I still consider them part of the same essential package and it'd be nice not to have them split across namespaces anymore.

mike-sul commented 2 years ago

Can you do it manually?

Sure, that's exactly what I did.

The following can be a fix for the issue, too.

diff --git a/.gitmodules b/.gitmodules
index f932e085..0556ad66 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -1,6 +1,6 @@
 [submodule "tests/tuf-test-vectors"]
        path = tests/tuf-test-vectors
-       url = https://github.com/advancedtelematic/tuf-test-vectors/
+       url = https://github.com/advancedtelematic/tuf-test-vectors.git
 [submodule "third_party/googletest"]
        path = third_party/googletest
        url = https://github.com/google/googletest.git
pattivacek commented 2 years ago

The following can be a fix for the issue, too.

Okay, great, thanks! PR?

mike-sul commented 2 years ago

@pattivacek https://github.com/uptane/aktualizr/pull/30 (for some reason I cannot add a reviewer to the PR).