search

uptane / aktualizr

C++ Uptane Client
Mozilla Public License 2.0
15 stars 15 forks source link

Add CMake command to run shellcheck. #65

Closed pattivacek closed 2 years ago

pattivacek commented 2 years ago

Note that this isn't quite the same as what CI is doing, since that has some extra magic to find shell scripts that don't end in .sh. I don't want to reimplement that here. However, I renamed the files I know about that didn't have that extension so that they have it, just to make it easier to find them.

Also, bump tuf-test-vectors and switch to uptane namespace.

pattivacek commented 2 years ago

Urgh, I remember something like this happening once before. I'm not immediately sure why it's failing on the submodule change.

cajun-rat commented 2 years ago

This is weird. I was going to rebased this on top of the buildfix so that we can get it in, but when I ran it locally I get a bunch of errors in makedeployed.sh and makephysical.sh like:

In tests/ostreesysroot/makephysical.sh line 51:
cd ${CURDIR}
   ^-------^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
cd "${CURDIR}"

The shellcheck CI rule passes, which is weird. It appears to be checking those files (it says it is...). I'm running the version in Debian Stable which is 0.7.1, vs 0.8.0 in CI which might be the issue. I'm happy to put those fixes in, but it weird that it passes today?

pattivacek commented 2 years ago

This is weird. I was going to rebased this on top of the buildfix so that we can get it in, but when I ran it locally I get a bunch of errors in makedeployed.sh and makephysical.sh like:

In tests/ostreesysroot/makephysical.sh line 51:
cd ${CURDIR}
   ^-------^ SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
cd "${CURDIR}"

The shellcheck CI rule passes, which is weird. It appears to be checking those files (it says it is...). I'm running the version in Debian Stable which is 0.7.1, vs 0.8.0 in CI which might be the issue. I'm happy to put those fixes in, but it weird that it passes today?

That is weird. This was actually blocked because of the tuf-test-vectors namespace change that was failing to fetch for reasons I couldn't figure out and still haven't had time to investigate. Maybe I should separate the two pieces.

pattivacek commented 2 years ago

I removed the tuf-test-vectors fix and put it in https://github.com/uptane/aktualizr/pull/73 so that this can proceed.

pattivacek commented 2 years ago

grrrr what happened with codecov again? It was working just a few weeks ago, but now it's not posting anymore again. :(

pattivacek commented 2 years ago

Can I get a review on this?