Test an update if metadata version is the same while their content have been changed

[mike-sul]

Add a test that verify whether aktualizr can perform an update if targets and corresponding snapshot and timestamp metadata are updated while their version is the same. This test is specifically dedicated for the recent fix to the imagerepo functionality https://github.com/uptane/aktualizr/commit/9d3ee3ae1b1c8a0d0739fbc29664efa05f57d57f

[mike-sul]

@pattivacek I am not sure whether I should add the change to advancedtelematic/tuf-test-vectors repo or uptane/tuf-test-vectors. Aktualizr refers to the former, so I pushed the change to it https://github.com/advancedtelematic/tuf-test-vectors/pull/77. Also, I am confused how your commit ended up in that PR.

[codecov-commenter]

Codecov Report

Merging #69 (b4a83b3) into master (4345dee) will decrease coverage by 0.00%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   84.44%   84.43%   -0.01%     
==========================================
  Files         172      172              
  Lines       12255    12255              
==========================================
- Hits        10349    10348       -1     
- Misses       1906     1907       +1     

Impacted Files	Coverage Δ
src/libaktualizr/storage/sqlstorage_base.h	60.00% <0.00%> (-40.00%)	:arrow_down:
src/libaktualizr/storage/sqlstorage_base.cc	76.19% <0.00%> (-0.69%)	:arrow_down:
src/aktualizr_info/main.cc	91.98% <0.00%> (+0.76%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4345dee...b4a83b3. Read the comment docs.

[mike-sul]

If I rollback the fix, then the test yields the following error messages

Skipping Image repo Snapshot download; stored version is still current.
Skipping Image repo Targets download; stored version is still current.
1 new update found in both Director and Image repo metadata.
New updates found in stored Director metadata. Checking stored Image repo metadata...
Hash verification for Snapshot metadata failed
Failed to check Image repo metadata: Snapshot metadata hash verification failed

[pattivacek]

I am not sure whether I should add the change to advancedtelematic/tuf-test-vectors repo or uptane/tuf-test-vectors. Aktualizr refers to the former, so I pushed the change to it advancedtelematic/tuf-test-vectors#77. Also, I am confused how your commit ended up in that PR.

See my comment in https://github.com/advancedtelematic/tuf-test-vectors/pull/77#pullrequestreview-937933552.

If I rollback the fix, then the test yields the following error messages

Great, that seems to tell us that the test is working! It's unfortunate that the error message wasn't very helpful. It was sort of an edge case we were hoping to ignore, so I'm not too surprised there that it isn't very clear. At least it did reject the metadata as expected.

[pattivacek]

Does this need to get updated to point to the master branch instead of the now-merged branch?

[mike-sul]

Does this need to get updated to point to the master branch instead of the now-merged branch?

I guess it has been already done?

[pattivacek]

I guess it has been already done?

Haha, that's what I just did. :) I'm gonna merge now.