search

uptane / aktualizr

C++ Uptane Client
Mozilla Public License 2.0
15 stars 15 forks source link

Bump tuf-test-vectors and switch to uptane namespace. #73

Closed pattivacek closed 1 year ago

pattivacek commented 2 years ago

Split out from https://github.com/uptane/aktualizr/pull/65 since this has been surprisingly error-prone.

codecov-commenter commented 1 year ago

Codecov Report

Merging #73 (8a9595b) into master (bb38516) will increase coverage by 0.08%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
+ Coverage   84.40%   84.49%   +0.08%     
==========================================
  Files         172      172              
  Lines       12256    12256              
==========================================
+ Hits        10345    10356      +11     
+ Misses       1911     1900      -11
Impacted Files Coverage Δ
src/aktualizr_info/main.cc 91.98% <0.00%> (+0.76%) :arrow_up:
src/libaktualizr/storage/sqlstorage_base.cc 79.59% <0.00%> (+4.76%) :arrow_up:
src/libaktualizr/storage/sqlstorage_base.h 100.00% <0.00%> (+40.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb38516...8a9595b. Read the comment docs.

pattivacek commented 1 year ago

Wow, this took forever to sort out. I finally fixed it. From the last commit:

Manually fetch the submodules in github CI.

    The automatic fetching logic breaks in really confusing ways when the
    submodule origin has changed. It really doesn't make sense. This is a
    really naïve workaround. It is hopefully just a temporary fix that can
    be reverted at a later time, but at least for now, it seems to be
    necessary in order to get CI to pass on this branch.
mike-sul commented 1 year ago

It is hopefully just a temporary fix that can be reverted at a later time, but at least for now, it seems to be necessary in order to get CI to pass on this branch.

It's really odd indeed. I think the workaround can be reverted too.