search

uptane / deployment-considerations

Deployment Considerations and Best Practices for Uptane
Apache License 2.0
4 stars 8 forks source link

Adding some text on government updates #118

Closed jhdalek55 closed 3 years ago

jhdalek55 commented 3 years ago

This is still a bit rough. Feel free to make suggestions or amend this PR, but don't merge as of yet

jhdalek55 commented 3 years ago

This should be merged into Master and not Patch 3. I cant't seem to figure out how to do this.

jhdalek55 commented 3 years ago

I'm ready to have this looked at now.

jhdalek55 commented 3 years ago

@pattivacek your input is welcomed as well.

trishankatdatadog commented 3 years ago

Oh, hmm, we should set some branch protection settings here, such as requiring >= 2 reviews. Anyone object?

pattivacek commented 3 years ago

Oh, hmm, we should set some branch protection settings here, such as requiring >= 2 reviews. Anyone object?

I think it's just because it's currently set to merge into another branch. The main branch is protected. @jhdalek55 there should be an Edit button near the top of this PR for you and from there you can change the branch being merged into.

As far as the text, I think this is pretty far outside of my base of knowledge to comment meaningfully.

jhdalek55 commented 3 years ago

@trishankatdatadog you are probably right that we should mandate two reviews here as we do on the Standard. I have no objections to changing this. We may need to look into how we assign reviews though. Too often pull requests sit unmerged for a long time not because of legitimate debate on its merits, but just because the author can't even get one review.

trishankatdatadog commented 3 years ago

@trishankatdatadog you are probably right that we should mandate two reviews here as we do on the Standard. I have no objections to changing this. We may need to look into how we assign reviews though. Too often pull requests sit unmerged for a long time not because of legitimate debate on its merits, but just because the author can't even get one review.

I feel your pain, and such is the nature of open source work 😢 Perhaps the best we can do is to remind people at meetings.

jhdalek55 commented 3 years ago

This PR partially addresses Standard Issue #162.

jhdalek55 commented 3 years ago

Can we get one more review to close this out?

jhdalek55 commented 3 years ago

Ok, Patti, I've followed up on your comments. If you can approve this, I can merge.

jhdalek55 commented 3 years ago

Good eyes. Are we good to go now?

jhdalek55 commented 3 years ago

I've gotten two approvals, so I am going to close this one out. Thanks.