uptane / obsolete-reference-implementation

⚠️⚠️⚠️ Obsolete ⚠️⚠️⚠️ — This repository contains a reference implementation of a pre-1.0 version of the Uptane Standard and should not be used
https://uptane.github.io
MIT License
6 stars 6 forks source link

Move temporary demo code in primary.py to demo_primary.py #61

Open vladimir-v-diaz opened 7 years ago

vladimir-v-diaz commented 7 years ago

While working on the demo+attack doc, I came across code in the reference implementation that prints banners, which should instead exist in the demo modules. After speaking with @awwad, he stated that these banner statements are temporary, and will eventually be moved to the demo modules (e.g., demo.demo_primary.py instead of uptane/clients/primary.py). Opening this ticket so that it's documented in GitHub, instead of a comment in a module.

See: https://github.com/uptane/uptane/blob/79a5dae1a4f91ec6ba59143163064838485e68ed/uptane/clients/primary.py#L458-L463

awwad commented 7 years ago

Yeah, the reference implementation would otherwise keep running along, processing updates for other ECUs. Thanks for creating the issue.

There are two obvious ways to get the information about this back to the demo, where a banner can be printed:

I guess I lean toward the second, which is easier. The first may make things cleaner but may also make the workflow harder to grok.