uptane / uptane-standard

standard for Uptane
https://uptane.github.io
Other
37 stars 31 forks source link

Improve example hash naming #166

Closed zabbal closed 4 years ago

zabbal commented 4 years ago

Better align example SHA names with https://csrc.nist.gov/projects/hash-functions/nist-policy-on-hash-functions

While at it, also use example from different hash function families to emphasize the fact that we're not tied to a particular set of algorithms.

zabbal commented 4 years ago

Seems like I can't assign reviewers explicitly so just pinging in the comments: @trishankkarthik you might be interested. Others feel free to review as well of course.

iramcdonald commented 4 years ago

Hi Max,

Sorry for the delay. Explicitly reviewed the file changes and rationale. I approve!

Stay safe,

Ira McDonald (Musician / Software Architect)Co-Chair - TCG Trusted Mobility Solutions WG

Co-Chair - TCG Metadata Access Protocol SG

Chair - Linux Foundation Open Printing WGSecretary - IEEE-ISTO Printer Working GroupCo-Chair - IEEE-ISTO PWG Internet Printing Protocol WGIETF Designated Expert - IPP & Printer MIBBlue Roof Music / High North Inchttp://sites.google.com/site/blueroofmusic http://sites.google.com/site/blueroofmusichttp://sites.google.com/site/highnorthinc http://sites.google.com/site/highnorthincmailto: blueroofmusic@gmail.com blueroofmusic@gmail.com(permanent) PO Box 221 Grand Marais, MI 49839 906-494-2434

On Mon, Jun 22, 2020 at 1:32 PM Trishank Karthik Kuppusamy < notifications@github.com> wrote:

@trishankatdatadog approved this pull request.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/uptane/uptane-standard/pull/166#pullrequestreview-435136028, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE33UO3O7BV2Q37RAQV645DRX6IULANCNFSM4OE37YAA .

jhdalek55 commented 4 years ago

@zabbal thanks for this. We should probably take a look at the Deployment pages as well and make sure we are consistent.

zabbal commented 4 years ago

I've checked deployment-considerations there seems to be nothing related to SHA examples which needs updating there.

jhdalek55 commented 4 years ago

Thanks for checking, Max.