search

uptick / pymyob

A Python SDK for the MYOB Business (formerly AccountRight Live, and New Essentials) API.
BSD 3-Clause "New" or "Revised" License
18 stars 24 forks source link

Journal tran #65

Closed wardy3 closed 3 years ago

wardy3 commented 3 years ago

Add journal transaction query

However, the MYOB doco says you can only GET this endpoint.

When I specify GET instead of CRUD, pymyob looks like it insists on a uid= option to be passed in. It looks like the endpoints.py file is trying to simplify the support for multiple endpoints but the MYOB API is a bit inconsistent with the UID option.

So, the change I've made creates put post etc queries when they don't exist. Not sure how to fix this

jarekwg commented 3 years ago

I think in this case you want to put it in on two lines, using ALL and GET, like in this example: https://github.com/uptick/pymyob/blob/069431e17f86242dd2f57ed81955d935e3a735da/myob/endpoints.py#L74-L75

wardy3 commented 3 years ago

I think in this case you want to put it in on two lines, using ALL and GET, like in this example:

https://github.com/uptick/pymyob/blob/069431e17f86242dd2f57ed81955d935e3a735da/myob/endpoints.py#L74-L75

aaah i get it. i misunderstood "all". how's this?

jarekwg commented 3 years ago

Lovely!

jarekwg commented 3 years ago

Out in 1.2.17.

Thanks for contributing!