uptick / pymyob

A Python SDK for the MYOB Business (formerly AccountRight Live, and New Essentials) API.
BSD 3-Clause "New" or "Revised" License
18 stars 24 forks source link

x-myobapi-cftoken header not needed sometimes #68

Closed seb-b closed 2 years ago

seb-b commented 2 years ago

So I think from googling, if you are attached to a CompanyFile via my.myob.com you do not require the x-myobapi-cftoken header, and in fact when I do try to use it, I get a 401 (???). When I manually delete the header from request_kwargs before hitting an endpoint everything works ok, but if don't authenticate with a CompanyFile I get a KeyError('There are no stored username-password credentials for this company id.')

Is it possible to make the CF authentication optional? This project is great for helping with the nasty oauth flow I'd love to keep using it for the CRUD operations too

jarekwg commented 2 years ago

Hey @seb-b,

Thanks for your message. Might this be a dupe of #33? I'd love to deal with it, but our resourcing is a little slim at the moment. Happy to review a PR though if you want to put one forward.

seb-b commented 2 years ago

oh yep this is definitely a duplicate, same issue, I'll close this one.