uptick / react-interactive-tutorials

Framework for creating unobtrusive interactive tutorials for use in web apps.
MIT License
39 stars 7 forks source link

Add simple reference documentation #8

Open 1fifoto opened 5 years ago

1fifoto commented 5 years ago

Add simple reference documentation describing the layout of the tutorial as a Javascript object in alphabetical order by property. This would greatly help to better understanding the package's capabilities and potential. For example, something as simple as this indented list would help explain the depth and breadth of this package.

jarekwg commented 5 years ago

Hi 1fifoto,

Thanks for submitting such detailed issues! We don't at present have the resources to put much time into this package ourselves (we likely will again in the future at some point though eventually..), however if you want to go ahead and make a PR (for this or either of the other issues you've raised), we'll happily merge it in and publish a new version.

Cheers,

1fifoto commented 5 years ago

Hi jarekwg, Thanks for your response. I might take you up on your offer concerning a PR or two. A quick question regarding this one - ref doc. How would you prefer incorporating some more information: (1) add to the README.md or (2) add in a docs directory as markdown file or files or (3) add something else? if (2) then what filename would you prefer for the simple reference material shown above? Sincerely, Bri (AKA one-foot-in-front-of-the-other: 1fifoto)

1fifoto commented 5 years ago

Did a PR for a simple one line README.md file change. Trying out the PR process. Tell me if I did OK. It looks like it created a new issue so I probably should not put a preceding issue number such as I did. Future will change from "9 Minor: Fix built css in README" => "Minor: Fix built css in README"

jarekwg commented 5 years ago

Just in README.md is fine. If you have the energy to spin up something more elaborate, a docs folder is good, or a whole readthedocs setup thingy. :)

You can link to an existing issue in your PR description, using the magic words Fixes #<PR_NUMBER>, which will automatically close the issue when the PR is merged.

Cheers!