search

uptick / react-keyed-file-browser

Folder based file browser given a flat keyed list of objects, powered by React.
MIT License
305 stars 145 forks source link

Allow to create folders when onRenameFolder is not provided #106

Closed fbessou closed 4 years ago

fbessou commented 4 years ago

The early return in handleRenameSubmit was only checking for renameFolder presence but we don't need this to create a folder.

Maybe we should have a distinct handleCreateSubmit method and extract common code in a helper function/private method.

ziaulrehman40 commented 4 years ago

Oh sorry, i fixed this in my PR https://github.com/uptick/react-keyed-file-browser/pull/110 as well, because you had not linked to the issue, i thought that is still open.

I would suggest you may close this PR and we use mine because that also bumps react-dnd version, which allows for better extensibility.

fbessou commented 4 years ago

No problem, let's move to your PR then :)