Closed oliverfoster closed 4 years ago
I agree that it's a bit weird including the src folder, especially if the webpack config to build it is not included. I think typically you'd want to keep what is uploaded to npm as small as possible to minimize download time. Since this is an open source project you'd always be able to find the relevant source files on github. I'd recommend taking the following approach:
When installing the package into a new project, currently we have this:
and ideally we'd want this:
we'd have to:
.npmignore
file to exclude source/config/setup filesThat sounds excellent. I'll close this pr and leave someone else who knows better what they're doing to pick up that work. Thanks for responding.
resolves #135
Changed
.npmignore
exclude directive for thesrc
folder to implicitly re-include thesrc
folder in the npm module