uptick / react-keyed-file-browser

Folder based file browser given a flat keyed list of objects, powered by React.
MIT License
298 stars 144 forks source link

issue/133 Added onDownloadFolder #141

Closed oliverfoster closed 3 years ago

oliverfoster commented 4 years ago

resolve #133

Added

Changed

oliverfoster commented 3 years ago

@jarekwg Is this feasible? Have you managed to take a look?

jarekwg commented 3 years ago

Hi @oliverfoster, sorry for the wait. I'll get one of my colleagues to take a look soon.

oliverfoster commented 3 years ago

No worries, happy to amend if they've suggestions.

venky0195 commented 3 years ago

Hi, @jarekwg @oliverfoster @olivermartinfoster onDownloadFolder not working. I'm unable to download a folder. However, download files are working. <FileBrowser onDownloadFile={arrayOfSelectedItems => { console.log('downloadFile', arrayOfSelectedItems) }} onDownloadFolder={(arrayOfSelectedFolders) => { console.log('downloadFolder', arrayOfSelectedFolders) }} /> I'm getting console for onDownloadFile, but no download button when I click on folder. Thanks in advance

venky0195 commented 3 years ago

Also, there is only below code in browser.js in node modules. actionRenderer: ActionRenderer, onCreateFolder, onRenameFile, onRenameFolder, onDeleteFile, onDeleteFolder, onDownloadFile

There is no onDownloadFolder anywhere in the browser.js

oliverfoster commented 3 years ago

These changes haven't been released yet. You'd have to use the master branch. Are you sure you have the code from this pr?