uptick / react-keyed-file-browser

Folder based file browser given a flat keyed list of objects, powered by React.
MIT License
298 stars 144 forks source link

Option to download folder #150

Closed venky0195 closed 3 years ago

venky0195 commented 3 years ago

Hi, I'm unable to download a folder. However, download files is working. <FileBrowser onDownloadFile={arrayOfSelectedItems => { console.log('downloadFile', arrayOfSelectedItems) }} onDownloadFolder={(arrayOfSelectedFolders) => { console.log('downloadFolder', arrayOfSelectedFolders) }} /> I'm getting console for onDownloadFile, but no download button when I click on folder. Thanks in advance

venky0195 commented 3 years ago

Also, there is only below code in browser.js in node modules. actionRenderer: ActionRenderer, onCreateFolder, onRenameFile, onRenameFolder, onDeleteFile, onDeleteFolder, onDownloadFile

<ActionRenderer browserProps={browserProps}

    selectedItems={selectedItems}
    isFolder={selectionIsFolder}

    icons={icons}
    nameFilter={this.state.nameFilter}

    canCreateFolder={typeof onCreateFolder === 'function'}
    onCreateFolder={this.handleActionBarAddFolderClick}

    canRenameFile={typeof onRenameFile === 'function'}
    onRenameFile={this.handleActionBarRenameClick}

    canRenameFolder={typeof onRenameFolder === 'function'}
    onRenameFolder={this.handleActionBarRenameClick}

    canDeleteFile={typeof onDeleteFile === 'function'}
    onDeleteFile={this.handleActionBarDeleteClick}

    canDeleteFolder={typeof onDeleteFolder === 'function'}
    onDeleteFolder={this.handleActionBarDeleteClick}

    canDownloadFile={typeof onDownloadFile === 'function'}
    onDownloadFile={this.handleActionBarDownloadClick}
  />

There is no onDownloadFolder anywhere in the browser.js

mwfister commented 3 years ago

Hi Venky, the latest release doesn't have the changes that includes the onDownloadFolder. I'm in the process of putting together a release. After it's released, if you still are having troubles, feel free to re-open this issue and we can look into it

mwfister commented 3 years ago

@venky0195 You can now update to 1.10.0 to use onDownloadFolder

venky0195 commented 3 years ago

Thanks @mwfister !