uptick / react-keyed-file-browser

Folder based file browser given a flat keyed list of objects, powered by React.
MIT License
298 stars 144 forks source link

delete with multi selection call onDeleteFolder #156

Open djangoliv opened 3 years ago

djangoliv commented 3 years ago

When you select 2 files and confirm delete, the onDeleteFile function is call but the onDeleteFolder is call too.

Regards

DIntriglia commented 3 years ago

Can confirm this as well

rodriguezd commented 3 years ago

This is most annoying. If you pass a boolean to the onDeleteFolder prop which is valid prop type, the code complains that onDeleteFolder is not a function because it still tries to execute it as a function. If you pass a null function, you avoid the not a function exception, but then the folder containing the files to be deleted is "deleted" from the listing. You have to reload it for it to appear again.