feat: noFilesMessage can be a component + added noMatchingFilesMessage

tmarcinkowski-logitech commented 3 years ago

Description

The message for "no files" scenario can be only a text. I've extended proptypes to allow using a component. The message for "no files matching the name filter" scenario is hardcoded. I've added a new prop to allow customizing that message.

Changelog

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested manually in our codebase.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules
[x] I have checked my code and corrected any misspellings

seanmadi commented 2 years ago

These changes are great, and I need them really badly. I've been using a forked repo for a couple of years, and now after upgraded realized the only three strings left that aren't translatable are these ("No Files" and "No Files matching {}") and "Show more results". @tmarcinkowski-logitech let me know if I can help with the tests or whatever you need. I'd like to add "Show more results" as another prop to this as well, in the same file.

tmarcinkowski-logitech commented 2 years ago

@seanmadi As far as I'm concerned there is no real blocker. It is all up to @dreadera to find the best time to merge and release this change.

tmarcinkowski-logitech commented 2 years ago

I merged additional changes from @seanmadi into my branch (thanks again!).

@dreadera What's your view on merging that into your main branch and releasing as a new version?

uptick / react-keyed-file-browser