search

uptick / react-keyed-file-browser

Folder based file browser given a flat keyed list of objects, powered by React.
MIT License
295 stars 143 forks source link

React 18 support #251

Open ikappaki opened 4 months ago

ikappaki commented 4 months ago

Hi,

could you please consider patch to upgrade the dependencies to support React 18. It fixes #228.

The approach taken here is to change as little as possible to make the lib compatible with React 18.

I have manually tested to work via storybook, which has also been upgraded to the latest version.

react-dnd could not be seamlessly upgraded due to the deprecation of the DragSource, DropTarget API in 15.0 in favor of the new useDrag hooks.

The change in the package script command line invocation to use npx ... is to support invocation on MS-Windows.

I have not endeavored to changed the demo-site because it appears as if it requires the package to be published first before picked up by the demo project.

Thanks

jarekwg commented 4 months ago

Hey @ikappaki -- we're seeking new maintainers for this package. Would you be interested?

ikappaki commented 4 months ago

Hey @ikappaki -- we're seeking new maintainers for this package. Would you be interested?

Hi @jarekwg, thank you for the offer but unfortunately my Javascript knowledge is very basic, given also the complexity of the ecosystem, whence the minimalistic update in this PR. I am consuming the package in ClojureScript.

nearone commented 3 months ago

Do you have some updates on this?

jarekwg commented 3 months ago

Hey Peeps, Apologies, but we're no longer actively maintaining this package. We're happy for someone who has time to wear maintainer hat to review&merge the open PRs, and republish. PM me!

trungleduc commented 3 months ago

Hi @jarekwg, I'm interested in maintaining this package. Currently, I'm maintaining a few NPM packages in the Jupyter ecosystem (https://www.npmjs.com/~trungleduc). Where can I contact you for more discussion?

jarekwg commented 3 months ago

Awesome! Email me at jarek.glowacki@uptickhq.com

ikappaki commented 3 months ago

Small correction with latest commit, react 18.x should be included as a peerDependency instead of replacing the existing ones.