uptick / react-keyed-file-browser

Folder based file browser given a flat keyed list of objects, powered by React.
MIT License
301 stars 144 forks source link

support for copy actions #66

Closed rschick closed 4 years ago

rschick commented 5 years ago

Not sure if this is the right approach, I wanted copy file/folder buttons..

rschick commented 4 years ago

@scaredcat any interest in this? If so I will fix merge conflicts.

jarekwg commented 4 years ago

@rschick what do you mean by "copy" in this case? To clipboard, or in place (ie immediate paste)? If it's the latter, i'd suggest the wording "duplicate", as it feels more apt. "Copy", as used these days, generally implies to clipboard.

I guess this opens a whole can of worms whether each action name should be configurable too. :D

Alternatively, perhaps we should provide more generic support for custom actions, because the implementation of this function will be up to the user anyway.. all you're adding here is a name pointing to a callback. What do you think?

jarekwg commented 4 years ago

The alternative I mentioned could help address #96 at the same time maybe?

scaredcat commented 4 years ago

closing due to no response