search

uptrace / helm-charts

Uptrace Helm Chart for Kubernetes
https://uptrace.dev/get/install.html
Apache License 2.0
19 stars 18 forks source link

Allow to define service annotations to be used with external load balancers as alternative to ingress #3

Closed alexandrujieanu closed 1 year ago

alexandrujieanu commented 1 year ago

Hello,

I am deploying uptrace on AWS EKS and providing external access using the AWS LB Controller which requires a set of service metadata.annotations to detect it and provision the LB.

It would be useful if the helm chart supported it.

Thanks.

vmihailenco commented 1 year ago

Hey,

Would be glad to help, but I barely understand the half of what you just said :) If it is not too much trouble, consider sending a PR.

alexandrujieanu commented 1 year ago

I opened a PR with the changes that work in the case I described.

vmihailenco commented 1 year ago

@alexandrujieanu thanks :+1: Could you please take a look at https://github.com/uptrace/helm-charts/pull/5? Any other hints we should add to the docs?

alexandrujieanu commented 1 year ago

Thank you for merging the PR. I will suggest more details to #5.