Closed pragmaticivan closed 5 months ago
Thanks for the PR, but otelzap now uses Otel Logs API which has top-level fields for trace & span ids.
Hi @vmihailenco could you clarify that? this PR is backward compatible, it happens that many vendors don't follow the same API yet
and this would be required to support New Relic for example.
@pragmaticivan otelzap now does not inject trace_id/span_id and instead relies on Otel Logs API to do it automatically: https://github.com/uptrace/opentelemetry-go-extra/blob/main/otelzap/otelzap.go#L164-L196
And Otel Logs API will set trace/span ids on the log.Record
structure directly without using attributes.
would be required to support New Relic for example.
New Relic would just need to support OpenTelemetry Logs API.
fixes #109