uptrend-tech / uptrend-redux-modules

Collection of modules useful to redux based react apps.
MIT License
5 stars 1 forks source link

ResourceLoader appending params={} #27

Closed orther closed 6 years ago

orther commented 6 years ago

Reported by Dylan in Slack

Relevant code or config

<ResourceListLoader
  resource={`org/${orgId}/application/${planAppId}/land`}
  loadOnMount
/>

What you did: Loaded a list with the ResourceLoader without passing params.

What happened: Actual request made was with params get param: http://localhost:3000/api/v1/org/194/application/123/land?params=%7B%7D

Suggested solution:

  1. Do not add params as a GET param. Instead add items in the params object.
  2. Do not add params if the object is empty.
orther commented 6 years ago

:tada: This issue has been resolved in version 0.6.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: