Closed diffalot closed 3 years ago
This was supposed to fail too, but it skipped the strict type checking too. I'll have to figure out what I set up wrong.
A Perfect Failure For The Win!!!!! and this means optin to strict type checking is as easy as including typescript in the branch name. I'm gonna close this and make that happen in a PR to main
yarn run watch:types:strict
starts up the typscript checker with strict rules enabled and updates on file changesyarn run types:strict
is for the ci to run if PR targets the typescript branchThe pr can easily be started from the command line through the GitHub CLI with
gh pr create --base typescript
or through the web interface, just make sure to maketypescript
the target base.There are some disadvantages to this, mainly that if no one writes any types or uses the types that have already been written, it's gonna be a bad day for whoever opts in to strict type checking because they will be forced to write types for all the bits of code that have been comitted since someone last did a PR through this part of the pipeline