upward-dev / Upward

open source project for the tech community - let's learn from each other
GNU General Public License v3.0
3 stars 4 forks source link

Added Typescript with optional strict checking #8

Closed diffalot closed 3 years ago

diffalot commented 3 years ago

The pr can easily be started from the command line through the GitHub CLI with gh pr create --base typescript or through the web interface, just make sure to make typescript the target base.

There are some disadvantages to this, mainly that if no one writes any types or uses the types that have already been written, it's gonna be a bad day for whoever opts in to strict type checking because they will be forced to write types for all the bits of code that have been comitted since someone last did a PR through this part of the pipeline

diffalot commented 3 years ago

This was supposed to fail too, but it skipped the strict type checking too. I'll have to figure out what I set up wrong.

diffalot commented 3 years ago

A Perfect Failure For The Win!!!!! and this means optin to strict type checking is as easy as including typescript in the branch name. I'm gonna close this and make that happen in a PR to main