search

upwork / phystrix

Phystrix is a latency and fault tolerance library for PHP, inspired by Netflix’s Hystrix
Apache License 2.0
1 stars 0 forks source link

[WIP] PSR-6 Cache implementation of state storage #22

Closed neeckeloo closed 7 years ago

lcf commented 7 years ago

tests fail, also @neeckeloo could you first file an issue for each pull request and explain reasoning and the kind of issues you've been having so that we can discuss and choose the best solution

neeckeloo commented 7 years ago

You can see #25 to understand why this PR build failed.

Do not you think you've closed the pull request a little prematurely? IMO, a pull request can aim to start a discussion like an issue.

I proposed to implement a state storage based on PSR-6 Cache interfaces to improve flexibility. Currently, the package allow only to use APC to store metrics.

neeckeloo commented 7 years ago

No interest in this proposal? If not, I will have to create a small repository with this state storage implementation.

lcf commented 7 years ago

@neeckeloo could you first file an issue for each pull request and explain reasoning and the kind of issues you've been having so that we can discuss and choose the best solution.