upwork / phystrix

Phystrix is a latency and fault tolerance library for PHP, inspired by Netflix’s Hystrix
Apache License 2.0
1 stars 0 forks source link

Requiring at least PHP 5.6 as minimum installed PHP version #23

Closed neeckeloo closed 7 years ago

lcf commented 7 years ago

@neeckeloo I do not follow. Why?

lcf commented 7 years ago

@neeckeloo could you first file an issue for each pull request and explain reasoning and the kind of issues you've been having so that we can discuss and choose the best solution

neeckeloo commented 7 years ago

I suggest to require PHP 5.6 as minimum PHP version because PHP 5.5 is now EOL and older versions (PHP 5.3 and 5.4) are not supported since a while.

http://php.net/supported-versions.php

lcf commented 7 years ago

@neeckeloo You are not required to use PHP 5.3 or PHP 5.4 to use Phystrix. It works with newer PHP versions as well.