search

uq-its-ss / design-system

10 stars 5 forks source link

fix: ITSADSSD-55778 Hero-basic, closing div for uq-contianer in wrong location #514

Closed Bcrunk closed 6 months ago

Bcrunk commented 6 months ago

Closing div for uq-container was incorrectly wrapped in the tabs function. Which resulted in the non tab version of HERO-BASIC rendering without a closing DIV for uq-container class

Screenshot 2024-04-16 at 11 13 10 AM

uqds-github-bot commented 6 months ago

:sparkles: :sparkles: That's perfect, there is no visual difference! :sparkles: :sparkles:

You can check the report out here.

uqds-github-bot commented 6 months ago

Storybook preview https://uq-ds-regsuit.s3.amazonaws.com/storybook-preview/8698446523/index.html