uqbar-project / wollok-lsp-ide

IDE for Wollok - LSP node-based
GNU General Public License v3.0
7 stars 3 forks source link

Better ux #152

Closed PalumboN closed 7 months ago

PalumboN commented 7 months ago

Fix https://github.com/uqbar-project/wollok-lsp-ide/issues/148 Fix https://github.com/uqbar-project/wollok-lsp-ide/issues/151 Fix https://github.com/uqbar-project/wollok-lsp-ide/issues/118 Fix https://github.com/uqbar-project/wollok-lsp-ide/issues/126

Varios fize' luego de hacer una pruebas y recibiendo feedback de docentes.

También arreglé los tests e2e en el CI 🥳 Pero hay un test que rompe, no sé por qué, lo vimos con Ivo y en el IDE está funcionando.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 71.69811% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 84.28%. Comparing base (933cba9) to head (7cf4351).

Files Patch % Lines
server/src/utils/text-documents.ts 57.14% 12 Missing :warning:
server/src/utils/vm/wollok.ts 83.33% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #152 +/- ## ========================================== + Coverage 83.17% 84.28% +1.11% ========================================== Files 11 16 +5 Lines 309 420 +111 Branches 80 94 +14 ========================================== + Hits 257 354 +97 - Misses 52 66 +14 ``` | [Flag](https://app.codecov.io/gh/uqbar-project/wollok-lsp-ide/pull/152/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uqbar-project) | Coverage Δ | | |---|---|---| | [lsp-ide-client](https://app.codecov.io/gh/uqbar-project/wollok-lsp-ide/pull/152/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uqbar-project) | `91.73% <100.00%> (?)` | | | [lsp-ide-server](https://app.codecov.io/gh/uqbar-project/wollok-lsp-ide/pull/152/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uqbar-project) | `81.27% <68.75%> (-1.91%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=uqbar-project#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PalumboN commented 7 months ago

@fdodino probando lo de buscar el package.json en el CI me di cuenta que no estaba funcando para Windows (o sea que siempre estaba tomando todo el path desde el origen).

Hacer la tranformación de algo que llega en el LSP como

file:///d%3A/a/wollok-lsp-ide/wollok-lsp-ide/client/testFixture/pepitaGame/juego

a algo como lo que espera el fs

D:\a\wollok-lsp-ide\wollok-lsp-ide\client\testFixture\pepitaGame\juego

No era muy trivial, así que opté por volver al plan original de hacerlo en base al workspace folder. Te aviso por si querés revisarlo otra vez, porque cambió bastante la implementación (básicamente ya no se usa la función que busca el package.json pa'rriba).