search

uqbar-project / wollok

Wollok Programming Language
GNU General Public License v3.0
60 stars 16 forks source link

Writing arithmetic expressions in REPL has a weird behaviour #1033

Closed matifreyre closed 7 years ago

matifreyre commented 7 years ago

Writing this:

> 1 + 2

And pressing enter right there, without anything else, doesn't evaluate the expression. Instead, it just adds a NL/CR and you can continue writing. If you press enter, another NL/CR is added. If you add a space and then press enter, the expression gets evaluated.

Now, if you press the up arrow to recall the last expression and delete all the extra NL/CR and leave only the original expression > 1 + 2 with no space at the end, it does get evaluated.

After that last case where you get the expression evaluated, deleting the last 2 and writing it again doesn't change the behaviour, it keeps getting evaluated, but deleting + 2 and writing it again causes the same problem, so my belief is that this problem is somehow related with writing arithmetical operations. Instead, I don't have any problems with expressions like 1..5, so I believe it's not related with operators in general, just arithmetic.

fdodino commented 7 years ago

@matifreyre I could not reproduce it in Linux. I think it could be again a difference between NL and NL / CR in Linux and Windows.

fdodino commented 7 years ago

@matifreyre does it happen to you in dev branch? Still not happening to me...

tesonep commented 7 years ago

I could reproduced it in OSX, I think it has to do with the parser. The secret is not having nothing between the last '1' and the enter. It is like it is waiting for something more.

tesonep commented 7 years ago

In OSX the problem is when you use the enter in the numpad. If you use the normal enter it is working, can you check the same???

tesonep commented 7 years ago

@matifreyre @fdodino @npasserini

matifreyre commented 7 years ago

OK... I'll have a look at it tonight, I don't have the environment available right now.

On Fri, Apr 21, 2017 at 12:29 PM, Pablo Tesone notifications@github.com wrote:

In OSX the problem is when you use the enter in the numpad. If you use the normal enter it is working, can you check the same???

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/1033#issuecomment-296223066, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ-EZkMfCcSpPT2v58W8OA7nw97U5iR7ks5ryMtWgaJpZM4KkF9V .

tesonep commented 7 years ago

@matifreyre I have fixed with the help of Polito, because he is the master of keycode events in Pharo.