search

uqbar-project / wollok

Wollok Programming Language
GNU General Public License v3.0
60 stars 16 forks source link

IDE should produce a warning before executing a project with errors. #394

Closed npasserini closed 7 years ago

fdodino commented 7 years ago

It is done for tests, I'm not sure for a program, but it is easy to achieve if you see Test Launcher.

fdodino commented 7 years ago

See WollokTestLaunchShortcut in org.uqbar.project.wollok.ui.tests.shortcut, method launch()

npasserini commented 7 years ago

On saturday, this annoyed me a little. I think it might be ok to produce a warning, but I didn't like that it forbid me to run any test, I think it could be nicer to be a bit more flexible.

2017-04-21 14:44 GMT-03:00 Fernando Dodino notifications@github.com:

See WollokTestLaunchShortcut in org.uqbar.project.wollok.ui.tests.shortcut, method launch()

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/394#issuecomment-296257203, or mute the thread https://github.com/notifications/unsubscribe-auth/AEa1OZmyNF6VxRftgwt8ciNTj9KzybAoks5ryOr4gaJpZM4GiF7O .

fdodino commented 7 years ago

But otherwise you get no error message and no output (if you try to run tests in a .wtest file dhat does not compile). Ok, maybe the best approach could be to run tests that are ok, but i think it is not simple to achieve.

npasserini commented 7 years ago

Maybe I wasn't clear. I do not want "no error message and no output". What I would love is the eclipse (for Java/XTend/...) regular behaviour: receive the warning message, but allow me decide to run anyway. I am not sure here if you just do not like the idea or you think is better to forbid execution on any error or it is just that the "warning + run anyway" option was just in front of me and I didn't see it.

Anyway, I do not like the "no output" in any case. If a test can not be run because it can not be parsed, it should appear in the test report. If no test was found, that should also be reported. I guess all of this can be really difficult, but just the warning message could do it for now and we can planify the improved reporting for the next iteration.

2017-04-27 15:13 GMT-03:00 Fernando Dodino notifications@github.com:

But otherwise you get no error message and no output (if you try to run tests in a .wtest file dhat does not compile). Ok, maybe the best approach could be to run tests that are ok, but i think it is not simple to achieve.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/394#issuecomment-297795407, or mute the thread https://github.com/notifications/unsubscribe-auth/AEa1OQetkM1uate-OFTnmks0cZ8v0kMxks5r0NqsgaJpZM4GiF7O .

fdodino commented 7 years ago

"I am not sure here if you just do not like the idea or you think is better to forbid execution on any error or it is just that the "warning + run anyway" option was just in front of me and I didn't see it." None of them. :smile:

I like the idea. But since recovering from a parse / link / whatever error seemed a hard task, I preferred to avoid such a bad behavior. Ok, let's just warn user and make an improvement later.

npasserini commented 7 years ago

:+1:

2017-04-28 6:59 GMT-03:00 Fernando Dodino notifications@github.com:

"I am not sure here if you just do not like the idea or you think is better to forbid execution on any error or it is just that the "warning + run anyway" option was just in front of me and I didn't see it." None of them. 😄

I like the idea. But since recovering from a parse / link / whatever error seemed a hard task, I preferred to avoid such a bad behavior. Ok, let's just warn user and make an improvement later.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/394#issuecomment-297959177, or mute the thread https://github.com/notifications/unsubscribe-auth/AEa1OQVp_m1ODAyoPHphV4bqzbSNxCWMks5r0bh_gaJpZM4GiF7O .