search

uqbar-project / wollok

Wollok Programming Language
GNU General Public License v3.0
60 stars 16 forks source link

Include type system plugins in product bundles #947

Closed javierfernandes closed 7 years ago

javierfernandes commented 8 years ago

Although make it disable by default.

Currently we are not even including them in the product, because, as it currently is implemented one of the plugin adds an extension point which always extends both the label provider and the static checker with type system validations.

The validation has a preference and can be disabled, but the label extension not, and therefore the typesystem is always "working" even if you disabled it.

We need to make it fully "disabled" removing any typesystem content from the UI. And a way to make it enable. Then we can include the plugins in the end product

npasserini commented 7 years ago

Is this already done @javierfernandes ?

tesonep commented 7 years ago

@npasserini This is not done yet, the product does not include this plugin. If I include the plugin, I put the TS as active or inactive as default (I suggest active), but what do you think?

npasserini commented 7 years ago

I would like to have the type system active by default, but that should depend on the opinion of the testers in the next two weeks.

2017-07-11 6:20 GMT-03:00 Pablo Tesone notifications@github.com:

@npasserini https://github.com/npasserini This is not done yet, the product does not include this plugin. If I include the plugin, I put the TS as active or inactive as default (I suggest active), but what do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/947#issuecomment-314385456, or mute the thread https://github.com/notifications/unsubscribe-auth/AEa1OSAalRm1jz5f9uSHnmxYw3mdUKnfks5sMz5igaJpZM4JvEDS .

tesonep commented 7 years ago

What is the typeSystem to activate, cause I see many implementations?? The dev branch is up to date?

On Wed, Jul 12, 2017 at 12:50 AM, Nico Passerini notifications@github.com wrote:

I would like to have the type system active by default, but that should depend on the opinion of the testers in the next two weeks.

2017-07-11 6:20 GMT-03:00 Pablo Tesone notifications@github.com:

@npasserini https://github.com/npasserini This is not done yet, the product does not include this plugin. If I include the plugin, I put the TS as active or inactive as default (I suggest active), but what do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/947# issuecomment-314385456, or mute the thread https://github.com/notifications/unsubscribe-auth/ AEa1OSAalRm1jz5f9uSHnmxYw3mdUKnfks5sMz5igaJpZM4JvEDS .

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/947#issuecomment-314594019, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVsf_Wr82-KHh90vPdTRi4B2Po1ED9Pks5sM_wpgaJpZM4JvEDS .

-- Pablo Tesone. tesonep@gmail.com

npasserini commented 7 years ago

ConstraintBasedTypeSystem.

2017-07-12 4:39 GMT-03:00 Pablo Tesone notifications@github.com:

What is the typeSystem to activate, cause I see many implementations?? The dev branch is up to date?

On Wed, Jul 12, 2017 at 12:50 AM, Nico Passerini <notifications@github.com

wrote:

I would like to have the type system active by default, but that should depend on the opinion of the testers in the next two weeks.

2017-07-11 6:20 GMT-03:00 Pablo Tesone notifications@github.com:

@npasserini https://github.com/npasserini This is not done yet, the product does not include this plugin. If I include the plugin, I put the TS as active or inactive as default (I suggest active), but what do you think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/947# issuecomment-314385456, or mute the thread https://github.com/notifications/unsubscribe-auth/ AEa1OSAalRm1jz5f9uSHnmxYw3mdUKnfks5sMz5igaJpZM4JvEDS .

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/947# issuecomment-314594019, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVsf_Wr82- KHh90vPdTRi4B2Po1ED9Pks5sM_wpgaJpZM4JvEDS .

-- Pablo Tesone. tesonep@gmail.com

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/947#issuecomment-314682009, or mute the thread https://github.com/notifications/unsubscribe-auth/AEa1OShEdYTsUu_sYC5FasgxhOjG0Yutks5sNHgagaJpZM4JvEDS .