search

uqbar-project / wollok

Wollok Programming Language
GNU General Public License v3.0
60 stars 16 forks source link

wollok.lang.Exception: Non-terminating decimal expansion; no exact representable decimal result. #993

Closed mmatos closed 8 years ago

mmatos commented 8 years ago

After release 1.5.1 the following code started failing

40 / 55 wollok.lang.Exception: Non-terminating decimal expansion; no exact representable decimal result. at wollok.lang.Integer./(other) [classpath:/wollok/lang.wlk]

This should behave the same as:

40.0 / 55.0 0.7272727272727272727272727272727273

fdodino commented 8 years ago

Solved in branch fix-#993-division-numbers

matifreyre commented 8 years ago

I don't think we should wait until 1.5.2 to merge this one. What do you think @tesonep @javierfernandes @npasserini ?

npasserini commented 8 years ago

I am pretty lost about the changes to numbers, so I would trust you. Anyway, why do you think it shouldn't be integrated?

matifreyre commented 8 years ago

On the contrary... I'm saying we shouldn't wait, not that we shouldn't integrate

On Mon, Sep 26, 2016 at 10:20 AM, Nico Passerini notifications@github.com wrote:

I am pretty lost about the changes to numbers, so I would trust you. Anyway, why do you think it shouldn't be integrated?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/993#issuecomment-249567238, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ-EZis3bFSCRnGci0btcS5qVr4plNy_ks5qt8aSgaJpZM4KBt2X .

npasserini commented 8 years ago

Ah, ok. In that case... the only way to have the fix in the students' computers is to make a new release... that normally will be named 1.5.2.

So what we could do is just create a new release 1.5.2, right now without waiting for any other fix than this one. For me there is no problem.

tesonep commented 8 years ago

The best way is the release, I think it is a good moment if you we want to add anything else.

On Mon, Sep 26, 2016 at 3:31 PM, Nico Passerini notifications@github.com wrote:

Ah, ok. In that case... the only way to have the fix in the students' computers is to make a new release... that normally will be named 1.5.2.

So what we could do is just create a new release 1.5.2, right now without waiting for any other fix than this one. For me there is no problem.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/993#issuecomment-249569977, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVsfyCreq6XZ8-YgIXhbbAALiS7rDXBks5qt8k0gaJpZM4KBt2X .

Pablo Tesone. tesonep@gmail.com

matifreyre commented 8 years ago

If it's the only way, then yes, I'd like this issue solved because something as simple as "x / 3" will almost always fail. I have 2 really small PRs that we could add to the release if someone reviews them.

On Mon, Sep 26, 2016 at 10:35 AM, Pablo Tesone notifications@github.com wrote:

The best way is the release, I think it is a good moment if you we want to add anything else.

On Mon, Sep 26, 2016 at 3:31 PM, Nico Passerini notifications@github.com wrote:

Ah, ok. In that case... the only way to have the fix in the students' computers is to make a new release... that normally will be named 1.5.2.

So what we could do is just create a new release 1.5.2, right now without waiting for any other fix than this one. For me there is no problem.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/993# issuecomment-249569977, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVsfyCreq6XZ8- YgIXhbbAALiS7rDXBks5qt8k0gaJpZM4KBt2X .

Pablo Tesone. tesonep@gmail.com

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/uqbar-project/wollok/issues/993#issuecomment-249571086, or mute the thread https://github.com/notifications/unsubscribe-auth/AJ-EZsqPT7VHwSrNhkfr0j9CFjDqAgXsks5qt8o_gaJpZM4KBt2X .