ur-whitelab / hoomd-tf

A plugin that allows the use of Tensorflow in Hoomd-Blue for GPU-accelerated ML+MD
https://hoomd-tf.readthedocs.io
MIT License
30 stars 8 forks source link

iter_from_trajectory documentation: unit mismatch in 'start' and 'end' keyword arguments #290

Closed geemi725 closed 3 years ago

geemi725 commented 3 years ago

The documentation specifies units of start and end arguments as 'ns', but universe.trajectory.time is in ps.

Suggestion: avoid unit mismatches by reading frame numbers instead?

mehradans92 commented 3 years ago

addressed in #296