Closed RainierBarrett closed 2 years ago
Hello @RainierBarrett! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
htf/utils.py
:Line 512:30: W291 trailing whitespace Line 1006:89: W291 trailing whitespace Line 1007:89: W291 trailing whitespace Line 1008:89: W291 trailing whitespace
@RainierBarrett you still working on this? Looks like you just need to fix your whitespace.
Function updates look good. Will approve when PEP 8 issue is addressed.
@geemi725 I thought e38da36 was the only pep8 change needed. Is something else missing?
Oh it's not shown as fixed for some reason. Good job with PR
Hi @geemi725 and @RainierBarrett, this is still failing due to issue identified by pep8:
E File "/usr/share/miniconda/lib/python3.7/site-packages/hoomd/htf/utils.py", line 858
E if type(cg_positions) == tf.Tensor:
E ^
E TabError: inconsistent use of tabs and spaces in indentation
Ahh, I see it was in the test output, not the github bot. I recently set up a new machine and I guess I forgot to configure my editor. I'll address this, give me a little bit.
@RainierBarrett looks MDAnalysis 2.0 version is killing our CI. Can you add MDAnalysis < 2.0 to CI?
This PR is a small optimization to the functions like
mol_angle
that take in CG indices so they can take in the whole list of CG index pairs at once instead of one pair at a time, when CG_positions is a tensor.