search

ur0 / lolcat

lolcat, now with fearless concurrency.
MIT License
99 stars 14 forks source link

Rainbowize help #12

Closed SlooowAndFurious closed 2 years ago

SlooowAndFurious commented 4 years ago

This fixes issue #3 by displaying a nice rainbow as the help message. Here is a screenshot

SlooowAndFurious commented 4 years ago

Well, it looks like clap::App::write_help does not return the generated help for --help and --version, I did not read this in the docs, so I guess I should report this. I suggest not accepting this pull request while it is not fixed

ur0 commented 4 years ago

Thanks for the great PR. I’ll track the upstream issues too.

SlooowAndFurious commented 4 years ago

It looks like it won't be fixed before release 3.0.0 according to issue 808, so, a workaround is to use clap::App::write_long_help instead. I will do this

ur0 commented 2 years ago

Unfortunately, clap v3 is still in beta, but #17 resolved this in another way. I'm closing this in favor of the other one, but wish to thank you for your effort anyways!