search

ur0 / lolcat

lolcat, now with fearless concurrency.
MIT License
99 stars 14 forks source link

Rainbowize help, but better #17

Closed magnus-ISU closed 2 years ago

magnus-ISU commented 2 years ago

This pull request rainbowizes the help in a different way than the other merge request, so that it has to change less code to achieve it. To print the help with a custom method, it adds explicit options for -h and -V to the clap object.

It doesn't have the same issues that the other method does. It also adds no overhead if the -h or -V flags are not passed; I don't think this is the case for the other MR.

I bumped the version number of the program as well, to 1.0.2.

ur0 commented 2 years ago

Hi @magnus-ISU -- thank you for the PR, this seems like the perfect way to rainbowize the help screen. I'm merging this, and am curious if you would like to maintain this project going forward as I'm unable to dedicate any time to it right now.

magnus-ISU commented 2 years ago

I'm unsure myself. It is essentially feature-complete, there is only one bug which I'm not sure can even be fixed (the one about sl), so it is difficult to say whether I would be able to do anything anyway.

I might try fixing it, though. If you like, you could add me as a maintainer, then I could handle the pull requests myself.