search

uradotdesign / task-management

Internal Repo for Ura Design tasks and workflow
4 stars 0 forks source link

Temporary droplet for Thunderbird Styleguide #90

Closed AnXh3L0 closed 5 years ago

AnXh3L0 commented 6 years ago

We need to have a temporary droplet for the Thunderbird styleguide we're working on to test changes until it's complete.

Please update us on the progress as you as you create the droplet. Thanks!

kominoshja commented 6 years ago

Can you please be more specific on what this droplet needs to have? Also, this should mainly be @LuisTepshi responsibility

AnXh3L0 commented 6 years ago

The droplet should build from this repo: https://github.com/anxh3l0/photon (it uses npm) just like the other droplets we're using for our other websites based on GitHub.

elioqoshi commented 6 years ago

This is for @LuisTepshi indeed. @Borisbudini should have an overview role in case there is any blocker but not until that

LuisTepshi commented 6 years ago

@AnXh3L0 I installed the platform, however npm said that there where some dependencies that caused high vulnerabilities because they were not updated. Can you please update them first?

AnXh3L0 commented 6 years ago

@LuisTepshi Thank you; I believe we can leave the dependencies for later when we finalize the project because for now we just need the droplet so we can check the changes in real time.

LuisTepshi commented 6 years ago

@AnXh3L0 I've sent you the logs. I've set up automation so by the time you'll update it, it will be reflected automatically.

AnXh3L0 commented 6 years ago

Great, thanks! I'll make sure to update the dependencies asap after auditing them.

elioqoshi commented 6 years ago

@AnXh3L0 update on this?

AnXh3L0 commented 5 years ago

@elioqoshi this will be fixed today in the evening and the updated package.json file will be pushed in the repo.

elioqoshi commented 5 years ago

Thanks! We need to be sure it's ready to go as the project has been already published

AnXh3L0 commented 5 years ago

Sure, will do; I'll also open an issue in the FirefoxUX repo so they also update the dependencies since some of them were of critical severity and can be exploited by pretty much anyone.

AnXh3L0 commented 5 years ago

Dependency fix has been pushed; closing this.

elioqoshi commented 5 years ago

Thanks @AnXh3L0 did you also report this to the Firefox upstream branch?

AnXh3L0 commented 5 years ago

@elioqoshi yes I did open an issue about it.