uraimo / run-on-arch-action

A Github Action that executes jobs/commands on non-x86 cpu architectures (ARMv6, ARMv7, aarch64, s390x, ppc64le, riscv64) via QEMU
BSD 3-Clause "New" or "Revised" License
679 stars 150 forks source link

Better dockerRunArgs handling, ensure slug is lowercase, add install parameter #18

Closed elijahr closed 4 years ago

elijahr commented 4 years ago

Some dockerRunArg values would fail, due to improper handling of quotes. This is sidestepped by parsing the arguments into an array using shlex, then passing that array's items as separate N arguments to run-on-arch.sh.

It also seems that the container names must be lower-case, so we ensure the slug() function returns a lower-case string. Some GitHub repositories will have upper-case letters.

Edit: I've also added an install input parameter, which runs as part of docker build. This allows dependency installation to be cached in a docker image layer that persists between builds.

uraimo commented 4 years ago

Thanks!! 2.0.2 tagged!

elijahr commented 4 years ago

Thank you!