uraran / genplus-gx

Automatically exported from code.google.com/p/genplus-gx
Other
0 stars 0 forks source link

[libtretro] add more configurable settings #350

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Please implement config reading/parsing in libretro port instead of use 
hardcoded config.* values in libretro.c.

Original issue reported on code.google.com by 0vet...@gmail.com on 10 Jul 2013 at 12:40

GoogleCodeExporter commented 9 years ago
Shouldn't core configuration, including config file loading and saving, be 
handled by libretro frontend, i.e retroarch and RGUI ?

How is it done with other cores, do they really manage configuration file 
access themselves ? How would the core know the filepath to use considering it 
can be very platform dependent ? What is current status with genesis plus gx in 
retroarch, are core options In RGUI resetted to default everytime the core is 
restarted ?

I wouldn't mind adding more core options to RGUI (although, from my initial 
testing, it is not very practical for handling lot of options) and provide a 
way to load/save them but i would need more infos on how it is supposed to be 
done with retroarch...

Original comment by ekeeke31@gmail.com on 10 Jul 2013 at 3:02

GoogleCodeExporter commented 9 years ago

Original comment by ekeeke31@gmail.com on 14 Jul 2013 at 4:15

GoogleCodeExporter commented 9 years ago

Original comment by ekeeke31@gmail.com on 1 Nov 2013 at 10:16

GoogleCodeExporter commented 9 years ago

Original comment by ekeeke31@gmail.com on 1 Nov 2013 at 10:16

GoogleCodeExporter commented 9 years ago
Added in r844

Original comment by ekeeke31@gmail.com on 27 Nov 2013 at 10:18

GoogleCodeExporter commented 9 years ago
thanks a lot Eke!
works fine here
http://img43.imageshack.us/img43/8468/rdbi.png

btw, there was necessary few changes in Makefile.libretro to build it using (at 
least) MAME's  MinGW
http://pastebin.com/CsLkjGGb

Original comment by 0vet...@gmail.com on 28 Nov 2013 at 6:14

GoogleCodeExporter commented 9 years ago
one more thing

  var.key = "dac_bits";
  environ_cb(RETRO_ENVIRONMENT_GET_VARIABLE, &var);
  {
    if (!strcmp(var.value, "original"))

but there no "original" option value

{ "dac_bits", "YM2612 DAC quantization; disabled|enabled" },

Original comment by 0vet...@gmail.com on 28 Nov 2013 at 6:57

GoogleCodeExporter commented 9 years ago
thanks for the notice, it's indeed a left over from my first implementation, 
will fix it...

as for your Makefile issues, I did not change anything in that file from the 
initial implementation by retroarch devs so it must be something with your 
setup, missing installed libs (zlib and the one that provides crc32 function) 
seem to be the root cause there.

however, I agree it's odd  to provide the crc32 function through a source file 
in libretro but not compile it, I wonder why they did it that way

Original comment by ekeeke31@gmail.com on 28 Nov 2013 at 7:33

GoogleCodeExporter commented 9 years ago
its kind of funny, but the reason is crc32 function )

its linked from zlib by current makefile.libretro (and only it needed, the rest 
of zlib not used), or from scrc32.c in my variant of makefile and in MSVC 
projects.

Original comment by 0vet...@gmail.com on 30 Nov 2013 at 12:35